[vlc-devel] [PATCH] input: remove decoder buffering from es_out.c and decoder.c.

Rémi Denis-Courmont remi at remlab.net
Tue Dec 10 19:13:56 CET 2013

On Tue, 10 Dec 2013 19:10:03 +0100, Felix Abecassis
<felix.abecassis at gmail.com> wrote:
> I just want to add that I realized this patch is modifying an highly
> sensitive part of the code, a tiny change can introduce a nasty race
> condition and break seek/pause/audio... on some configurations.
> The patch looks OK on the configurations I've tested but that would be
> great if I could get a code review and some help with testing this
> change.

I totally agree that the post-decoder buffers are useless, and often
counter-productive, but this is hard to review. Did you consider splitting
the patch, in say, five?

Rémi Denis-Courmont
Sent from my collocated server

More information about the vlc-devel mailing list