[vlc-devel] [PATCH] input: remove decoder buffering from es_out.c and decoder.c.

[Rafaël Carré]

Felix Abecassis <felix.abecassis at gmail.com> a écrit :
>Except for readability considerations I don't think this patch should
>be splitted.
>
>This patch removes some members of the p_sys structure and rename
>other members (related to buffering but still needed). This triggers
>the deletion of many lines of code and afterwards also triggers some
>refactoring such as deleting now useless 'for' loops. I agree that
>changing the indentation of some lines totally messes up the diff

git 's -w option is handy for viewing these kind of changes
 so I
>can still split the patch in 2-3 for the sake of readability.
>
>2013/12/10 Rémi Denis-Courmont <remi at remlab.net>:
>> On Tue, 10 Dec 2013 19:10:03 +0100, Felix Abecassis
>> <felix.abecassis at gmail.com> wrote:
>>> I just want to add that I realized this patch is modifying an highly
>>> sensitive part of the code, a tiny change can introduce a nasty race
>>> condition and break seek/pause/audio... on some configurations.
>>> The patch looks OK on the configurations I've tested but that would
>be
>>> great if I could get a code review and some help with testing this
>>> change.
>>
>> I totally agree that the post-decoder buffers are useless, and often
>> counter-productive, but this is hard to review. Did you consider
>splitting
>> the patch, in say, five?
>>
>> --
>> Rémi Denis-Courmont
>> Sent from my collocated server
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.