[vlc-devel] [PATCH 3/3] mediacodec: implementation of MediaCodec direct rendering based on the work by Martin Storsjö.

[Martin Storsjö]

On Fri, 13 Dec 2013, Felix Abecassis wrote:

> Since decoder buffering has been removed, this patch should work on all devices.
> I'm now waiting for feedbacks from Martin but I think this patch could
> be merged soon if no one has further objections.

I guess that's a pretty bold assumption. Yes, some of the preliminaries 
have been fixed now, but did this patch get a proper review by someone who 
knows the internals properly?

IMO in general it looks kinda ok to me - some details are a little bit 
unorthodox, but the alternatives are just as good/bad. I've got a few 
minor comments on the patch.

In general this seems to work pretty well on my Galaxy S3 now - kudos for 
that. However, if pausing the video, waiting for a little while (a few 
seconds) and then pressing the back key to exit, something somewhere seems 
to deadlock.

// Martin