[vlc-devel] [PATCH] Add secure transport TLS module

[Felix Paul Kühne]

Hey David,

On 14.12.2013, at 00:50, david.fuhrmann at gmail.com wrote:

> +/* From MacTypes.h (cannot be included because it isn't present in iOS: */
> +#define ioErr -36

Missing #ifndef?

> +		if(errno == EAGAIN) {
> +			retValue = errSSLWouldBlock;
> +            sys->b_blocking_send = true;
> +		} else {

Minor formatting inaccuracy.

> +        case noErr:
> +            msg_Dbg(session, "handshake completed sucessfully");
> +            return 0;

Typo.

> +        case errSSLUnknownRootCert:
> +            msg_Err(session, "Certificate verification failed, unknown root certificate");
> +            return -1;

vlc_dialog missing to match the gnutls module as this might be a self-signed certificate which the user would like to accept anyway.

> +        case errSSLCertExpired:
> +            msg_Err(session, "Certificate verification failed because its expired");
> +            return -1;

vlc_dialog missing to ask the user if s/he would like to continue anyway?

> +        case errSSLHostNameMismatch:
> +            msg_Err(session, "Certificate verification failed, hostname does not match");
> +            return -1;

Idem?

Cheers,

Felix