[vlc-devel] [PATCH 3/3] mediacodec: implementation of MediaCodec direct rendering based on the work by Martin Storsjö.

[Martin Storsjö]

On Mon, 18 Nov 2013, Felix Abecassis wrote:

> @@ -335,12 +355,33 @@ static int OpenDecoder(vlc_object_t *p_this)
>         (*env)->DeleteLocalRef(env, bytebuf);
>     }
>
> -    (*env)->CallVoidMethod(env, p_sys->codec, p_sys->configure, format, NULL, NULL, 0);
> -    if ((*env)->ExceptionOccurred(env)) {
> -        msg_Warn(p_dec, "Exception occurred in MediaCodec.configure");
> -        (*env)->ExceptionClear(env);
> -        goto error;
> +    p_sys->direct_rendering = var_InheritBool(p_dec, CFG_PREFIX "directrendering");

Did you test that the mediacodec decoder still works if direct rendering 
is disabled? I suspect you'll need to add some checks in 
InvalidateAllPictures at least.

// Martin