[vlc-devel] [PATCH 3/3] mediacodec: implementation of MediaCodec direct rendering based on the work by Martin Storsjö.

[Felix Abecassis]

Good point, thanks.

MediaCodec opaque direct rendering does not make sense with
transcoding since we need an Android surface for rendering. With this
assumption, would it now make sense to call
input_DecoderIsExitRequested?

But this raises another question I haven't thought of: is there a way
to know if the decoder was instantiated by a transcoder? Because if
this is the case we must disable opaque DR and use plain MediaCodec
with rendering into a picture_t.
Currently, in this situation I think the current code while wait
indefinitely for a Surface to be created since
jni_LockAndGetAndroidJavaSurface was modified recently to wait until
Java_org_videolan_libvlc_LibVLC_attachSurface is called. If this is
not possible we will probably need to add an optional timeout argument
for the LockAndGet functions.

2013/12/30 Rémi Denis-Courmont <remi at remlab.net>:
> Le lundi 30 décembre 2013, 14:37:31 Felix Abecassis a écrit :
>> I was able to reproduce this deadlock on N5. Thank you for pointing it.
>>
>> Could we promote the static function DecoderIsExitRequested from
>> src/input/decoder.c to the public API in include/vlc_input.h?
>
> I believe that function only works for a decoder instantiated by the input.
> That is not the only way to instantiate a decoder (e.g. transcode), so no.
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



-- 
Félix Abecassis
http://felix.abecassis.me