[vlc-devel] [PATCH] live555: fix the subtitles issue

[Gilles Chanteperdrix]

On 12/30/2013 06:32 PM, Ross Finlayson wrote:
> Now, to get back to the original topic of this email thread: The
> (small) patch that I provided (to the "modules/access/live555.cpp"
> code) fixes a problem (introduced between versions 2.0.9 and 2.1.0)
> that had prevented subtitles tracks from working properly.  FYI.

I believe RTSP streams with multiple audio tracks as well. Anyway, I
second Ross, has this fix any chance to get merged?

On the off-topic subject now:
> Gilles has also made another hack to *his* server to recognize the
> port number of these incoming 'dummy' packets, and use this to set
> the port number for his server's outgoing RTP packets.  As both Rémi
> and I have noted to Gilles, this is non-standard and potentially
> insecure, and I certainly won't be adding it to the LIVE555 RTSP
> server implementation, and I assume that VLC won't be adding it to
> their RTSP server implementation either.  But yes, Gilles, has hacked
> *his* server (just a hobbyist project, from what I can tell) so that
> it happens to work behind *his* NAT with *some* clients.
> Congratulations, Gilles, but please stop wasting our time harping on
> about this.  (The VLC developers and I have real work to do :-)

As I said, this can be made secure if the dummy packets sent by the
client contain the session ID instead of 0xfeedface. Yes, this is non
standard, but if I look at other free software projects, a lot are
implementing extensions; gcc, implements extensions to the C language,
the Linux kernel integrates extensions to the IP base protocols, glibc
implements extensions to the POSIX standard (even Ross implements
extensions to the RTSP standard in live555). Everybody is implementing
extensions, I believe this is the only way to get things working and
more importantly evolving. I do not pretend my hack is as valuable as
what these projects do. But it is not complicated, and it improves
things a great deal without breaking the situations that were already
working. But OK, I will say no more.

Sorry for the thread hijacking. Won't do it again.


-- 
                                                                Gilles.