[vlc-devel] [PATCH] too long timeouts in win32 vlc_poll

Rémi Denis-Courmont remi at remlab.net
Sun Feb 3 18:25:12 CET 2013

Le dimanche 3 février 2013 19:21:47, Rémi Denis-Courmont a écrit :
> Le dimanche 3 février 2013 13:01:04, Mario Speiß a écrit :
> > When vlc_poll is called with timeout of i.e. 5000ms it may happen that
> > the waiting time might be as long as 2500s ! Probably poll should be
> > called with the 50ms timeout as many times until the original provided
> > timeout has been reached.
> Yes the code is correctness-challenged. I wonder how I came up with such
> utter crap. But your patch does not solve the problem fully.

Hmm, the patch turns out to be correct, when the second poll() call is taken 
into accout.

To Rafaël's and my lame defense, that call is not visible in the diff :-$ 

Rémi Denis-Courmont

More information about the vlc-devel mailing list