[vlc-devel] [PATCH/RFC] libvlc: add language and frame rate to

[Jean-Baptiste Kempf]

On 04 Feb, Rémi Denis-Courmont wrote :
> +    /* Codec specific */
> +    int         i_profile;
> +    int         i_level;
> 
> Maybe add original codec too?

OK.

> +    } u;
> 
> Is this needed? I think recent C allows anonymous unions.

No idea. I copied a bit shamelessly.

> Hmm, I think the convention is not to have underscore before 2. Bit maybe just 
> libvlc_media_track_t...

OK.

> Please NOOO. This reproduces the exact same extensibility problem.

OK. Back to the design table :)
I will do a bit of research to understand.

Btw, void *reserved could help :D

> +            libvlc_media_fill_tracks_info( (libvlc_media_track_info_2_t 
> *)p_mes, p_es, false );
> 
> Not sure this cast respects the rules of C type aliasing.

No warnings for me, but I'll try to understand better.

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device