[vlc-devel] [PATCH] Puzzle filter enhancement

[Jean-Baptiste Kempf]

On 06 Feb, Vianney Boyer wrote :
> +                if (i_r >=0 && i_r < ps_shape->i_row_nbr) {

invert the if and continue

new function from here.


> +int puzzle_generate_sectTopB( filter_t *p_filter, piece_shape_t *ps_piece_shape, uint8_t i_plane)
> +int puzzle_generate_sectLeftB( filter_t *p_filter, piece_shape_t *ps_piece_shape, uint8_t i_plane)
> +int puzzle_generate_sectRightB( filter_t *p_filter, piece_shape_t *ps_piece_shape, uint8_t i_plane)
> +int puzzle_generate_sectBtmB( filter_t *p_filter, piece_shape_t *ps_piece_shape, uint8_t i_plane)

Please factorize (macros!)

> +int puzzle_generate_sectTop( filter_t *p_filter, piece_shape_t *ps_piece_shape, uint8_t i_pts_nbr, point_t *ps_pt, uint8_t i_plane)
> +int puzzle_generate_sectLeft( filter_t *p_filter, piece_shape_t *ps_piece_shape, uint8_t i_pts_nbr, point_t *ps_pt, uint8_t i_plane)
> +int puzzle_generate_sectLeft2Right( filter_t *p_filter, piece_shape_t *ps_piece_shape, piece_shape_t *ps_left_piece_shape, uint8_t i_plane)
> +int puzzle_generate_sectTop2Btm( filter_t *p_filter, piece_shape_t *ps_piece_shape, piece_shape_t *ps_top_piece_shape, uint8_t i_plane)

Idem and split.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device