[vlc-devel] [PATCH] gnutls: retry handshake if it returns a non-fatal error
etix at videolan.org
Thu Feb 7 17:08:08 CET 2013
On Thu, Feb 7, 2013 at 4:57 PM, Rafaël Carré <funman at videolan.org> wrote:
> Le 07/02/2013 16:46, Jean-Baptiste Kempf a écrit :
>> On 07 Feb, Rafaël Carré wrote :
>>> Le 07/02/2013 16:08, Ludovic Fauvet a écrit :
>>>> Based on the gnutls_handshake manual the function must be called again
>>>> until it returns 0 (or a fatal error).
>>> The non-fatal errors such as `GNUTLS_E_AGAIN' and
>>> `GNUTLS_E_INTERRUPTED' interrupt the handshake procedure, which
>>> should be later be resumed. Call this function again, until it
>>> returns 0; cf. `gnutls_record_get_direction()' and
>>> But we already return when meeting those non-fatal errrors.
>> There are other non-fatals errors that are not those 2.
> Hm ok it looks good then.
> The manual is confusing (why put these 2 on the same line?)
>From what I understand, these two need to resume the call to
gnutls_handshake at a later time and not within the loop.
More information about the vlc-devel