[vlc-devel] [PATCH] -- improving the art files user experience ....

brezhoneg1 brezhoneg1 at yahoo.fr
Tue Feb 12 01:16:27 CET 2013


    Please find an updated set of patches for review. It is aimed at 
improving art file display.

- patch1 :
   transform the core image module into a plugin module

- patch2 (no functional change) :
   merge the core image module as a submodule of the image demux
   create a Content2Fourcc function out of fenrir's content-based 
detection code

- patch3 :
   implement content detection when a still image is read with ImageReadUrl.

- patch4 (optional) :
    Remove extension for art files downloaded from the Internet.
    Since extension detection proves unreliable for art files blindly 
downloaded from the Internet, rather not set any extension. This patch 
is useful for the qt4 interface which uses QPixmap. This Qt class is 
extension-based if an extension is provided and fails if the extension 
is wrong. If no extension is provided, a content-based detection is 
performed and the same art file can then be displayed successfully.
     For this patch4, other ports (Apple, Android, ...) must agree, 
since this may impact their port.


Le 07/02/2013 15:22, Jean-Baptiste Kempf a écrit :
> On 29 Jan, brezhoneg1 wrote :
>>   modules/demux/image_helper.h |  334 ++++++++++++++++++++
> Way too much code in a header, IMVHO.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PatchesImage.tar.gz
Type: application/gzip
Size: 8971 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130212/b2d98042/attachment.bin>

More information about the vlc-devel mailing list