[vlc-devel] [PATCH 1/4] chromaprint: add stream out chromaprint module

[Francois Cartegnie]

Le 11/02/2013 17:40, Rémi Denis-Courmont a écrit :
>> **************************************************************************
>> *** + * Copyright (C) 2012 VLC authors and VideoLAN
> 
> Seems off.

Copyright starts once publicly published.

>> +        {
>> +            p_sys->p_data->i_duration = p_sys->i_total_samples /
>> p_sys->id->i_samplerate;
>> +            p_sys->p_data->psz_fingerprint = strdup( psz_fingerprint );
> 
> That's rather brittle. What if the same structure is reused?
> 
>> +            chromaprint_dealloc( psz_fingerprint );

I don't get what you're pointing out.


Francois