[vlc-devel] [PATCH] access: add rfb/vnc viewonly module.

Francois Cartegnie fcvlcdev at free.fr
Tue Feb 26 14:02:51 CET 2013


Le 24/02/2013 22:41, Rémi Denis-Courmont a écrit :
>>>> The fake+8bpp remoteosd filter trick being not sufficient and
>>> Yes. Please remove it in a separate patch.
>> Can't: Not intended for the same use.
> I don't see the implication.

remote_osd is to control a source through vnc.

>> "makes pointer from integer without a cast"
> 
> Then WTF did you submit the patch? After several years, you should know better 
> than to submit evidently broken patches.

That's just warnings.
I've switched key/tag to a function pointer, but that could be confusing
without reading API declaration.

>> Still needed for computing DEMUX_GET_TIME.
> 
> I don't see  that.

V4L2's demux also does this:
*va_arg (args, int64_t *) = mdate() - sys->start;

Francois




More information about the vlc-devel mailing list