[vlc-devel] [PATCH] access: add rfb/vnc viewonly module.

[Francois Cartegnie]

Le 26/02/2013 18:17, Rémi Denis-Courmont a écrit :
>> +            credential->x509Credential.x509CACrlFile =
>> +                    var_InheritString( p_demux, "http-crl" );
> 
> You are really being annoying. You keep complaining about the lack of 
> documentation and consistency. And then you ignore existing documentation and 
> violate consistency.
> 
> These settings are documented and that's not what they are meant for.

That's a mistake

>> +    for(;;)
>> +    {
>> +        if (! p_sys->p_block )
>> +        {
>> +            p_sys->p_block = block_Alloc( p_sys->i_framebuffersize );
>> +            msleep( p_sys->i_frame_interval );
> 
> WTF is this non-sense?
> 
> I'm stopping here.
> Come back when you've applied your critics to your own self.

As long as the block could not be allocated that loop would top 100%
cpu. Maybe it just would have been logical to swap the 2 lines or do a
conditional check for the sleep in that unlikely case.

Francois