[vlc-devel] [PATCH] XCB windowless: add x11-xcb pkgconfig check

Ludovic Fauvet etix at videolan.org
Fri Jan 4 15:59:07 CET 2013

On Fri, Jan 4, 2013 at 3:31 PM, Cheng Sun <chengsun9 at gmail.com> wrote:
> On 04/01/13 13:11, Ludovic Fauvet wrote:
>> We got rid of the HAVE_WINDOWLESS define few days ago. Why re-adding it?
> Because now if the user doesn't have x11-xcb, then we can only build the
> GTK windowed part of the plugin, not the windowless part.
> Hence, we need a check again.

Well, makes sense but re-introducing the HAVE_WINDOWLESS define is not
a good idea IMHO.
We should require them both and fail as soon as one is missing.

PKG_CHECK_MODULES(XCB, [xcb x11-xcb],[xcb_found=yes])
Something like that should do the trick.

>> Else it looks good to me.
>> Also please rebase your two patches.
> I thought they were already rebased against master. Unless you meant
> merge the two patches into one?

Yes please, merge both patches. It will be easier to understand as a whole.

Best regards,
Ludovic Fauvet

More information about the vlc-devel mailing list