[vlc-devel] [PATCH] macosx: Don't re-center extensions on every dialog update

Josh Watzman jwatzman at jwatzman.org
Sun Jan 6 08:27:18 CET 2013

If the user has moved the extension dialog, we don't want to re-center it on
every single update -- many extensions update their dialogs on every input
change, and this behavior can cause the extension dialog to keep re-overlapping
with the video, which is very frustrating.
 modules/gui/macosx/ExtensionsDialogProvider.m |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/modules/gui/macosx/ExtensionsDialogProvider.m b/modules/gui/macosx/ExtensionsDialogProvider.m
index 70351b6..8a286bb 100644
--- a/modules/gui/macosx/ExtensionsDialogProvider.m
+++ b/modules/gui/macosx/ExtensionsDialogProvider.m
@@ -539,10 +539,8 @@ static ExtensionsDialogProvider *_o_sharedInstance = nil;
         [dialogWindow setHas_lock:NO];
         BOOL visible = !p_dialog->b_hide;
-        if (visible) {
-            [dialogWindow center];
+        if (visible)
             [dialogWindow makeKeyAndOrderFront:self];
-        }
             [dialogWindow orderOut:nil];
-- (Apple Git-33)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 896 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130105/acd43798/attachment.sig>

More information about the vlc-devel mailing list