[vlc-devel] [PATCH] WinRT: define a simple WINRT define than WINAPI_FAMILY_APP

[Rafaël Carré]

Hello,

Le 2013-01-08 11:39, Jean-Baptiste Kempf a écrit :
> This will allow us to use #ifdef(WINRT) in the code
> ---
>   include/vlc_common.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/include/vlc_common.h b/include/vlc_common.h
> index d09bf78..356f4d6 100644
> --- a/include/vlc_common.h
> +++ b/include/vlc_common.h
> @@ -408,6 +408,9 @@ typedef int ( * vlc_callback_t ) ( vlc_object_t *,      /* variable's object */
>    * OS-specific headers and thread types
>    *****************************************************************************/
>   #if defined( WIN32 )
> +#   if defined( WINAPI_FAMILY_APP )

Shouldn't it be:

#if defined(_WINRT_DLL) || WINAPI_FAMILY=WINAPI_FAMILY_APP

?

> +#      define WINRT

What if MS starts defining WINRT?

Or if some library defines it as well to some other meaning?

> +#   endif
>   #   include <malloc.h>
>   #   ifndef PATH_MAX
>   #       define PATH_MAX MAX_PATH
>