[vlc-devel] [PATCH] Display title only once for one item

[Rémi Denis-Courmont]

Le samedi 12 janvier 2013 12:55:50, Denis Charmet a écrit :
> Fix #5715
> ---
>  include/vlc_input_item.h |    1 +
>  src/input/item.c         |    1 +
>  src/input/resource.c     |    4 ++++
>  3 files changed, 6 insertions(+)
> 
> diff --git a/include/vlc_input_item.h b/include/vlc_input_item.h
> index 0f9800d..537a158 100644
> --- a/include/vlc_input_item.h
> +++ b/include/vlc_input_item.h
> @@ -88,6 +88,7 @@ struct input_item_t
>      uint8_t     i_type;              /**< Type (file, disc, ... see
> input_item_type_e) */ bool        b_fixed_name;        /**< Can the
> interface change the name ?*/ bool        b_error_when_reading;/**< Error
> When Reading */
> +    bool        b_title_shown;       /**< Has the title already been
> shown? */ };

This will hide the title in a number of situation where it should be shown, 
since the input item is not recreated. In other words, I do not think this 
datum belongs in input_item_t.

Furthermore this looks race-prone.

-- 
Rémi Denis-Courmont
http://www.remlab.net/