[vlc-devel] [PATCH] Use waveOutSetVolume to set volume instead of pure software gain

[Denis Charmet]

Le mardi 15 janvier 2013 à 09:06:04, Rémi Denis-Courmont a écrit :
> On Tue, 15 Jan 2013 01:48:42 +0100, Denis Charmet <typx at dinauz.org> wrote:
> > ---
> >  modules/audio_output/waveout.c |   76
> >  ++++++++++++++++++++++++++++++++++++++--
> >  1 file changed, 74 insertions(+), 2 deletions(-)
> 
> I'm not sure the core allows changing the volume_set/mute_set callbacks
> after Open(). Also, I guess volume will not be adjustable after Stop() and
> until the next Start().
>
Well the callbacks are called, so it seems allow it (but it may be a
bug). I feared that the callbacks had to be set on Open but since other
callbacks are set during Start, I thought it was OK.
In any case I'll work the adjustable volume.

Thanks for the review.

Regards,

-- 
TypX
Le mauvais esprit est un art de vivre