[vlc-devel] [vlc-commits] Skins2: port Win32 code to UNICODE
Jean-Baptiste Kempf
jb at videolan.org
Tue Jan 15 12:51:50 CET 2013
On 15 Jan, RĂ©mi Denis-Courmont wrote :
> > @@ -477,10 +478,10 @@ void Win32Factory::changeCursor( CursorType_t type
> )
> > const
> >
> > void Win32Factory::rmDir( const string &rPath )
> > {
> > - WIN32_FIND_DATA find;
> > + WIN32_FIND_DATAA find;
> > string file;
> > string findFiles = rPath + "\\*";
> > - HANDLE handle = FindFirstFile( findFiles.c_str(), &find );
> > + HANDLE handle = FindFirstFileA( findFiles.c_str(), &find );
> >
> > while( handle != INVALID_HANDLE_VALUE )
> > {
>
> That does not look very UNICODE to me. IIRC, there is a long standing bug
> report about Skins2 being broken on Unicode file systems.
rmDir reimplemented with a totally different codepath.
Best regards,
--
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
More information about the vlc-devel
mailing list