[vlc-devel] [PATCH] Use waveOutSetVolume to set volume instead of pure software gain

[Denis Charmet]

Le mercredi 16 janvier 2013 à 12:47:16, Denis Charmet a écrit :
> ---
>  modules/audio_output/waveout.c |  128 +++++++++++++++++++++++++++++++++++++---
>  1 file changed, 120 insertions(+), 8 deletions(-)
>

Now while this takes the previous comments... it raises a new potential
problem. Since I got rid of volume.h, I had to choose between saving or
not the volume.

MSDN tells me that all the modifications I do on the volume are for this
only instance so if I change the volume on one instance of a vlc using a
waveout device it won't affect another instance of a vlc using the same
waveout device. Tested on both of my Windows 7 computers.
It doesn't affect the master audio.
Yet when we change the sound of vlc using this functions the windows
audio mixer cursor of this vlc instance will be affected by this changes.
But so is the pulse one on my computer.

Right now Waveout API doesn't let me nicely repercute changes in the
windows audio mixer on the VLC interface without calling
waveOutGetVolume.

And while writing this mail I realized that I forgot to reinitialize
b_soft in Stop. It is fixed locally which allow volume changes after
Stop or before Start.

Regards,
-- 
TypX
Le mauvais esprit est un art de vivre