[vlc-devel] [PATCH] ConfigLoadString loses the last character of strings

[Mario Speiß]

On 19.01.2013 09:46, Rémi Denis-Courmont wrote:
> Merged, thanks.
>
>
I encounter some problems after applying this patch so i checked some 
things (no guarantee that i am right but i want to describe what i 
noticed), I use Win7x64 with mingw w64 and qt-intf mostly.

Before this patch the module cache had *no* cache hits, so all modules 
load *and* unload on every startup. So far everything works fine.

After applying the patch the module cache now obviously *has* cache hits 
(the bug before the patch prevents this) and *no* modules are loaded as 
the configuration of the plugins.dat is used. So far, so good.

But if you try to modify some settings (in expert view) vlc crashed due 
to gettext-problems being caused by empty (i.e. NULL) config names!

Also, if you avoid this crash by only opening, saving and closing the 
settings, the settings file is much smaller compared to before the patch.

Last but not least vlc does not seem to parse the "plugins-cache" 
setting from vlcrc *before* the modules are loaded (i.e. this option has 
no use, the plugins.dat seems to be used anyway).

I would recommend to revert this for now and to find out what is causing 
trouble here.

Regards,
Mario