[vlc-devel] [PATCH] Make cached module configuration on 64 bits work again

[Rafaël Carré]

Le 24/01/2013 17:08, Rémi Denis-Courmont a écrit :
> Le jeudi 24 janvier 2013 15:27:07, Rafaël Carré a écrit :
>>> The bit fields containing b->removed
>>> etc. where not cached this way. That was also the reason for the qt
>>> expert configuration dialog when it came across "removed" configuration
>>> items (which where not recognized as removed by parsing plugins.dat).
>>>
>>> Making the i_flags 64 bits large on 64 bit compilation resolves that.
>>
>> How can we know on which platforms this happens, only by experimentation?
> 
> It seems the compiler is free to use any integer type to store the bits fields. 
> Expanding the size of the integer in the union cannot fix the problem in the 
> general case. A more involved/smarter fix is required.

Replacing bitfields by uint8_t flags and using bitops IMHO.