[vlc-devel] [PATCH] Make cached module configuration on 64 bits work again
Rafaël Carré
funman at videolan.org
Fri Jan 25 04:37:18 CET 2013
Le 24/01/2013 17:41, Rémi Denis-Courmont a écrit :
> Le jeudi 24 janvier 2013 18:10:29, Rafaël Carré a écrit :
>> Replacing bitfields by uint8_t flags and using bitops IMHO.
>
> That is hard because of those fucked-up UI plugins that access the
> configuration structure directly, instead of through LibVLC functions...
<decoder cipher=courmisch>
So "those fucked-up UI plugins" == qt4 and maybe macosx, for reading
b_internal and b_advanced flags.
I would understand (but not accept) the strong language if you had
written such a LibVLC function, but you did not.
So I ask you apologize for this totally undeserved comment.
Also those plugins don't in any way make things harder, attached patch
does exactly what I suggested.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-module_config_t-do-not-use-bitfields.patch
Type: text/x-patch
Size: 10727 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130125/1ef3b5b8/attachment.bin>
More information about the vlc-devel
mailing list