[vlc-devel] [vlc-commits] Add LIBAVUTIL_VERSION_CHECK (based on LIBAVCODEC_VERSION_CHECK)

[Rafaël Carré]

Le 25/01/2013 10:31, Rémi Denis-Courmont a écrit :
> Le vendredi 25 janvier 2013 08:11:13, Rafaël Carré a écrit :
>> vlc | branch: master | Rafaël Carré <funman at videolan.org> | Fri Jan 25
>> 07:08:11 2013 +0100| [a92d777d0b430070ebc6aff422aec622323a59bf] |
>> committer: Rafaël Carré
>>
>> Add LIBAVUTIL_VERSION_CHECK (based on LIBAVCODEC_VERSION_CHECK)
> 
> This cannot work.
> 
> When a libav feature is merged into FFmpeg, the FFmpeg version is *not* 
> changed (since it is already incorrectly higher).

Wrong, it *is* bumped.

Look at today's conversation between me and BtBn where he gives link to
the merge commit of ffmpeg.

I think Michael takes care of bumping version numbers when merging libav
features (for example libav bumped from 51.24 to 51.25, and FFmpeg from
51.41 to 51.42 for cpu flag mask)

> Hence, there is no simple 
> way to support FFmpeg versions with #ifdef, except for stuff that is only in 
> FFmpeg and missing in libav.
> 
> FFmpeg versioning is just totally broken. When you set yourself up as a 
> downstream, you have to use *separate* version numbers. Patching upstream's 
> number cannot work.

No patching at all is done, Michael uses MICRO number >= 100 in all
FFmpeg libraries