[vlc-devel] [PATCH] Make cached module configuration on 64 bits work again

[Rémi Denis-Courmont]

Le vendredi 25 janvier 2013 12:13:53, Rafaël Carré a écrit :
> Le 25/01/2013 10:33, Rémi Denis-Courmont a écrit :
> > Le vendredi 25 janvier 2013 05:37:18, Rafaël Carré a écrit :
> >> So I ask you apologize for this totally undeserved comment.
> > 
> > After the thankless hours I spent cleaning up module_t and partly
> > module_config_t, this is ABSOLUTELY OUTRAGEOUS.
> 
> Thankless hours do not give you the right to insult the work made by
> other people.

The comment is totally deserved. The way that the Qt4 plugin extracts 
configuration from the core is crap. It is not as bad and buggy as it used to 
be, thanks to many hours of work by me and pretty much only me.

And instead of encouraging me and thanking me to go forward with the rework, 
you ask me to apologize. Who the hell do you think you are?

> > But you seem to be again on a trip to piss me off since the last few
> > days.
> 
> I just wish you would look back at yourself and see that you are very
> liberal in your emails.

That's so hypocritical. You question my technical decisions, just because they 
inconvenience you or your work (e.g. LibVLC interface breakage). You blame my 
code for being undocumented, while it's actually specified but you cannot be 
bothered to read the specification (e.g. atomic operations). And then you blame 
the code for being confusing but fail to propose how it could be less so...

> I don't record anyone on this list use the term "fucking" when talking
> about your work for a start, so the least you could do is returning the
> same favor to others.

fucked-up, adjective:
- Damaged or poorly manufactured.
- Annoying, evil or wrong. 

I did not use the term fucking either. And even if I had written "crap" or 
"poorly written", "bug-prone" or "very ugly", it would just be as vexating to 
an hypothetical person attached to that code. I am not going to stop 
criticizing the code base just to avoid hypothetically hurting people's ego.

Otherwise, we can forget about the whole code review thing.

For the record, I think the people that *designed* the affected code have all 
left the project for many years. So much for their emotional attachment...

-- 
Rémi Denis-Courmont
http://www.remlab.net/