[vlc-devel] [PATCH] Make sure we use the correct luac version when using contribs

Rafaël Carré funman at videolan.org
Fri Jan 25 13:49:35 CET 2013


Le 25/01/2013 13:34, Rémi Denis-Courmont a écrit :
> Le vendredi 25 janvier 2013 06:32:06, Rafaël Carré a écrit :
>> ---
>>  configure.ac |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 02eb758..b1bd38e 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1524,6 +1524,9 @@ then
>>    AS_IF([test "${LUAC}" = "false"], [
>>      AC_MSG_ERROR([Could not find the LUA byte compiler.])
>>    ])
>> +  AS_IF([test -f ${CONTRIB_DIR}/lib/liblua.a -a `${LUAC} -o /dev/stdout
>> /dev/stdin | od -h | head -1 |cut -d' ' -f6` != 0404], [ +   
>> AC_MSG_ERROR([You need 32-bits luac when using using lua from contrib.]) +
>>  ])
>>  fi
>>  AM_CONDITIONAL(BUILD_LUA, [test "${have_lua}" = "yes"])
> 
> I very much doubt configure can rely on od, head and/or cut being available and 
> compatible with GNU ones.

We can use od in octal and head -n 1

> Furthermore I guess the check breaks big endian builds (PPC).

Why? the fields extracted should be sizeof(int) and sizeof(size_t), does
PPC have sizeof int == 8?



More information about the vlc-devel mailing list