[vlc-devel] [RFC] -- improving the art files user experience ....

[Rémi Denis-Courmont]

Le lundi 28 janvier 2013 17:26:35, brezhoneg1 a écrit :
>     So, I just duplicated fenrir's content-based detection code into vlc
> core (src/misc/image.c) and __ALL__ art files would then be displayed
> without any problem.

Moving code from plugins into the core is not desirable. It bloats the LibVLC 
run-time. And obviously, duplicating code is not a very good idea either.

>     So, the question, is : Would it be ok to move this content-based
> detection at the vlc core (src/misc/image.c) so that it can be used
> throughout vlc whenever a still image needs to be read ? Or, any other
> means to benefit from this detection  ?

IMHO, if some code needs to be moved, then the image code should be moved to 
the image plugin. The image handler interface is already modularized anyway. 

-- 
Rémi Denis-Courmont
http://www.remlab.net/