[vlc-devel] [PATCH 1/6] Fix Metadata marshalling when sending the PropertiesChanged signal

mirsal mirsal at mirsal.fr
Tue Jan 29 14:57:04 CET 2013

On Tue, 2013-01-29 at 00:55 +0000, Alex Merry wrote:
> VLC was getting kicked from the D-Bus when a track was stopped, because
> it was generating invalid data on the wire when sending the
> PropertiesChanged signal for the Metadata property.
> The issue was that if there was now no current track, GetInputMeta would
> never be called and the the variant would never be populated with the
> "a{sv}" structure that the call to dbus_message_iter_open_container
> claimed it would be.
> We now share the code that GetProperties used, which dealt with this
> correctly, although now both use CurrentInput (which is what the signal
> previously used) instead of CurrentPlayingItem (which is what
> GetProperties previously used).
> ---
>  modules/control/dbus/dbus_player.c | 57 +++++++++++++++++++++-----------------
>  1 file changed, 32 insertions(+), 25 deletions(-)

Applied with small changes (missing call to vlc_object_release() on
error path in MarshalMetadata and code style adjustments)

Thanks !
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130129/6c0c774a/attachment.sig>

More information about the vlc-devel mailing list