[vlc-devel] [PATCH 4/6] Standardise property getters in the D-Bus module

mirsal mirsal at mirsal.fr
Tue Jan 29 17:13:45 CET 2013


On Tue, 2013-01-29 at 00:55 +0000, Alex Merry wrote:
> There was a lot of repeated code, some of which properly checked return
> values and some of which didn't.  This is all replaced and folded into
> the GetProperty function of each interface.
> 
> A side-effect is that it should be more efficient (we only check the
> interface argument once instead of once for each property, and there
> should be a smaller overall code size).
> ---
>  modules/control/dbus/dbus_player.c    | 303 +++++-----------------------------
>  modules/control/dbus/dbus_root.c      | 201 +++++-----------------
>  modules/control/dbus/dbus_tracklist.c |  80 ++++-----
>  3 files changed, 110 insertions(+), 474 deletions(-)

Applied, thanks !

-- 
mirsal 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130129/cf46af37/attachment.sig>


More information about the vlc-devel mailing list