[vlc-devel] [PATCH] -- improving the art files user experience ....
brezhoneg1 at yahoo.fr
Thu Jan 31 01:45:17 CET 2013
trying to resend this patch in a compressed format, since it didn't
seem to reach the mail listing the first time. Maybe, it was too big.
Le 29/01/2013 02:41, brezhoneg1 a écrit :
> Please, find attached a patch for review. This is a first draft to
> check if this is the right direction to go into.
> It was tested and it is fully functional.
> Le 28/01/2013 21:37, Rémi Denis-Courmont a écrit :
>> Le lundi 28 janvier 2013 17:26:35, brezhoneg1 a écrit :
>>> So, I just duplicated fenrir's content-based detection code
>>> into vlc
>>> core (src/misc/image.c) and __ALL__ art files would then be displayed
>>> without any problem.
>> Moving code from plugins into the core is not desirable. It bloats
>> the LibVLC
>> run-time. And obviously, duplicating code is not a very good idea
>>> So, the question, is : Would it be ok to move this content-based
>>> detection at the vlc core (src/misc/image.c) so that it can be used
>>> throughout vlc whenever a still image needs to be read ? Or, any other
>>> means to benefit from this detection ?
>> IMHO, if some code needs to be moved, then the image code should be
>> moved to
>> the image plugin. The image handler interface is already modularized
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 12709 bytes
Desc: not available
More information about the vlc-devel