[vlc-devel] [vlc-commits] src: fix crash in getaddrinfo due to bugs in the OSX runtime

Rémi Denis-Courmont remi at remlab.net
Thu Jul 4 19:23:41 CEST 2013


Le jeudi 4 juillet 2013 19:39:59, Felix Paul Kühne a écrit :
> +#if defined(__APPLE__) && defined(AI_NUMERICSERV)
> +    /* work-around a segfault in libSystem on Darwin 12 and later
> +     * if AI_NUMERICSERV is set and servname is either NULL or "0"
> +     * radar://13058317 */
> +    if ((hints->ai_flags & AI_NUMERICSERV) && (servname == NULL ||
> (servname[0] == '0' && servname[1] == 0))) +        servname = (char
> *)"00";
> +#endif
> +

This makes absolutely no sense whatsoever.
Keep your crap code parctices to MacOS specific files.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list