[vlc-devel] [PATCH 23/48] vout: robustify "early" SPU blending

[Rémi Denis-Courmont]

Le mercredi 3 juillet 2013 00:29:25, Rafaël Carré a écrit :
> if (vout->p->spu_blend) {
> 
> > +        picture_t *blent = picture_pool_Get(vout->p->private_pool);
> > +        if (blent) {
> > +            VideoFormatCopyCropAr(&blent->format, &filtered->format);
> > +            picture_Copy(blent, filtered);
> > +            if (vout->p->spu_blend) {
> > +                picture_BlendSubpicture(blent, vout->p->spu_blend,
> > subpic); +                picture_Release(todisplay);
> > +                todisplay = blent;
> > 
> > 
> > +            } else
> > +                picture_Release(blent);
> 
> remove these

This else stanza is needed for PATCH 24/48 in any case. So removing it here 
does not save anything. Then since spu_blend is practically never NULL, this 
ends up making the code more complicated rather than simpler.

-- 
Rémi Denis-Courmont
http://www.remlab.net/