[vlc-devel] [PATCH] libvlc: inherit defaults when setting video title display

[Mark Lee]

I wasn't sure if you wanted me to do anything about it or not. Personally,
I think it does make sense that the title is *not* shown by default for
libvlc - but I thought you might prefer that the default behaviour was not
changed between releases.

Anyway, thanks for accepting the original patch.
On 7 July 2013 16:56, Rémi Denis-Courmont <remi at remlab.net> wrote:

> Le dimanche 7 juillet 2013 17:36:52, Mark Lee a écrit :
> > ---
> >  lib/media_player.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/media_player.c b/lib/media_player.c
> > index 376159f..2dfb53a 100644
> > --- a/lib/media_player.c
> > +++ b/lib/media_player.c
> > @@ -458,9 +458,9 @@ libvlc_media_player_new( libvlc_instance_t *instance
> )
> >      var_Create (mp, "amem-channels", VLC_VAR_INTEGER |
> VLC_VAR_DOINHERIT);
> >
> >      /* Video Title */
> > -    var_Create (mp, "video-title-show", VLC_VAR_BOOL);
> > -    var_Create (mp, "video-title-position", VLC_VAR_INTEGER);
> > -    var_Create (mp, "video-title-timeout", VLC_VAR_INTEGER);
> > +    var_Create (mp, "video-title-show", VLC_VAR_BOOL |
> VLC_VAR_DOINHERIT);
> > +    var_Create (mp, "video-title-position", VLC_VAR_INTEGER |
> > VLC_VAR_DOINHERIT); +    var_Create (mp, "video-title-timeout",
> > VLC_VAR_INTEGER | VLC_VAR_DOINHERIT);
>
> Yeah sure. Then again, we could also decree that the title is not shown by
> default with LibVLC. This does not affect the VLC anyhow.
>
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>


<http://apricasoftware.co.uk>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130707/8e16714c/attachment.html>