[vlc-devel] [vlc-commits] Allocation size mismatch (cid #1047372)

[Rafaël Carré]

Hello,

Le 13/07/2013 08:56, Rémi Duraffort a écrit :
> vlc | branch: master | Rémi Duraffort <ivoire at videolan.org> | Sat Jul 13 08:45:19 2013 +0200| [a18b713d24e7e08cb27aa0089f8f12efa4b225a9] | committer: Rémi Duraffort
> 
> Allocation size mismatch (cid #1047372)
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a18b713d24e7e08cb27aa0089f8f12efa4b225a9
> ---
> 
>  modules/codec/dvbsub.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/codec/dvbsub.c b/modules/codec/dvbsub.c
> index 5ab6071..f26013d 100644
> --- a/modules/codec/dvbsub.c
> +++ b/modules/codec/dvbsub.c
> @@ -817,7 +817,7 @@ static void decode_page_composition( decoder_t *p_dec, bs_t *s )
>      if( p_sys->p_page->i_region_defs == 0 ) return;
>  
>      p_sys->p_page->p_region_defs =
> -        malloc( p_sys->p_page->i_region_defs * sizeof(dvbsub_region_t) );
> +        malloc( p_sys->p_page->i_region_defs * sizeof(dvbsub_regiondef_t) );

I think sizeof(*p_sys->p_page->p_region_defs) is more resilient for
future similar errors.

>      if( p_sys->p_page->p_region_defs )
>      {
>          for( i = 0; i < p_sys->p_page->i_region_defs; i++ )