[vlc-devel] [PATCH 1/2] libvlc: add equalizer API

[Rémi Denis-Courmont]

On Wednesday 10 July 2013 20:44:54 Mark Lee wrote:
> > > diff --git a/src/audio_output/filters.c b/src/audio_output/filters.c
> > > index 41b23b4..ea451a3 100644
> > > --- a/src/audio_output/filters.c
> > > +++ b/src/audio_output/filters.c
> > > @@ -314,8 +314,7 @@ static int EqualizerCallback (vlc_object_t *obj,
> > 
> > const
> > 
> > > char *var, void *data)
> > > 
> > >  {
> > >  
> > >      const char *val = newval.psz_string;
> > > 
> > > -
> > > -    if (*val)
> > > +    if (!strcmp("equalizer", var) && *val)
> > 
> > Tautology.
> 
> Sorry, I don't understand this.

If var compares equal to "equalizer", then *var equals 'e' and is thus 
necessarily true.

-- 
Rémi Denis-Courmont
http://www.remlab.net/