[vlc-devel] [PATCH] freetype: fix NULL deref

[Tillmann Karras]

On 2013-07-16 19:08, Rémi Denis-Courmont wrote:
> On Saturday 13 July 2013 17:26:56 Tillmann Karras wrote:
> Should fix #8960.
> 
> I am not sure that this is completely correct:
> 
> if( p_face->family_name != NULL
> +                 && p_style->psz_fontname != NULL
> && !strcasecmp( p_face->family_name, p_style->psz_fontname )
> 
> Presumably, if both names are NULL, then they compare equal, no?

I looked it up and it turns out the behavior is undefined (according to 
section 7.1.4 of the final draft [0] of ISO/IEC 9899:2011 aka C11).

[0] http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1570.pdf