[vlc-devel] [PATCH] freetype: fix NULL deref

Tillmann Karras tillmann at selfnet.de
Wed Jul 17 03:01:05 CEST 2013

On 2013-07-14 19:40, Rafaël Carré wrote:
> Did you test it?
Yes, it fixes the bug for me. The reason I used the word "should" is 
that I'm not entirely sure why p_region_in->p_style->psz_fontname can be 
NULL in the first place. The code for rendering HTML suggests that this 
is to be expected in which case this fix is correct.

> If not can you share a sample?
I uploaded a small sample at [0]. I assume you know where to find it? 
The file is called video_with_embedded_font.mkv or something like that.

> Your patch looks ok but I think it should mention embedded fonts in the
> commit log.

[0] http://streams.videolan.org/upload/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-freetype-fix-NULL-deref.patch
Type: text/x-diff
Size: 2102 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130717/ac6cedb8/attachment.patch>

More information about the vlc-devel mailing list