[vlc-devel] [PATCH] dcp: Creation of access-demux module for DCP (using asdcplib)

[Jean-Baptiste Kempf]

On 12 Jul, Nicolas Bertrand wrote :
> +dnl  DCP plugin (using asdcplib)
> +dnl
> +AC_ARG_ENABLE(dcp,
> +  AS_HELP_STRING([--enable-dcp],[Digital Cinema Package support using asdcplib (default auto)]))
> +have_asdcp="no"
> +AS_IF([test "${enable_dcp}" != "no"], [
> +  AC_LANG_PUSH(C++)
> +  AC_CHECK_HEADERS( [[AS@&t at _DCP.h]], 
> +    [have_asdcp="yes"],
> +    [AS_IF( [test "${enable_dcp}" = "yes"],
> +      [AC_MSG_ERROR( [ ASDCP library cannot be found (needed for dcp module). Either use --enable-dcp=no or install asdcp library: http://www-dev.pub.cinecert.com/asdcplib/download/ ] )])
> +     ])
> +  AC_LANG_POP(C++)
> +])
> +AM_CONDITIONAL(HAVE_ASDCP, [test "${have_asdcp}" != "no"])

No .pc file, I guess?

> @@ -0,0 +1,1174 @@
> +/*****************************************************************************
> + * Copyright (C) 2012-2013 VLC authors and VideoLAN
> + *
> + * Authors:
> + *          Claire Etienne
> + *          Aurélie Sbinné
> + *          Pierre Villard <pierre dot villard dot fr at gmail dot com>
> + *          Samuel Kerjose
> + *          Julien Puyobro
> + *          Simona-Marinela Prodea <simona dot marinela dot prodea at gmail dot com>

And you?

> +#include <stdlib.h>
> +#include <iostream>
> +#include <string>
> +#include <dirent.h> /* for managing the directory */
> +
> +/* VLC core API headers */
> +#include <vlc_common.h>
> +#include <vlc_input.h>
> +#include <vlc_demux.h>
> +#include <vlc_plugin.h>
> +#include <vlc_xml.h>
> +#include <vlc_url.h>
> +#include <vlc_stream.h>

Do you need all those headers?

> +    set_description( N_( "DCP access-demux module" ) )

"Digital Cinema Package"?

> +int dcpInit ( demux_t *p_demux );
> +int parserXML ( demux_t * p_demux );
> +int assetmapPath( demux_t * p_demux );
> +int parserAssetmapXML ( demux_t * p_demux );
> +int parserCplXML ( demux_t * p_demux );
> +bool endsWith( const char * str, const char * suffix );
> +int initXMLParser( demux_t *p_demux, char * filePath, stream_t **p_stream, xml_t **p_xml, xml_reader_t **p_xmlReader );
> +void fillVideoFmt( video_format_t * fmt, unsigned int width, unsigned int height, unsigned int frame_rate_num, unsigned int frame_rate_denom );
> +void freeMemXML( xml_reader_t *p_xml_reader, xml_t *p_xml, stream_t *p_stream );
> +void freeMem( demux_t *p_demux );

Do you really need all those declared now?

> +            fcc = VLC_FOURCC( 'J', 'P', '2', 'K' );
VLC_CODEC_JPEG2000

> +            fcc = VLC_FOURCC( 'J', 'P', '2', 'K' );
idem

> +            fcc = VLC_FOURCC( 'm', 'p', 'g', 'v' );
VLC_CODEC_MPGV

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device