[vlc-devel] [PATCH] Handling prefered language in AsfSelectStream Better, bitrate sort and select algo Tested with asf containing 3, Videos and 24 Lang...

Rémi Denis-Courmont remi at remlab.net
Wed Jul 17 19:17:31 CEST 2013

On Wednesday 17 July 2013 19:04:11 Alain Degreffe wrote:
> With The Patch, the correct language is chosen with the best quality but
> without all unecessary streams...

For a certain definition of correct.

You are assuming that the correct audio track is the one that matches the 
audio language preferences. There is a reason why this can normally be 
selected in the UI; it's not as simple as that. For instance, many people 
prefer the original audio track with subtitles over dubbing.

Any VLC user who's had the problem before will have become used to having the 
first track and you are changing this. From that point of view, your patch is a 
regression. If this feature is of any significance, someone will find it and 
complain. As the default owner of the network input bugs, I do not fancy that 

Besides, you said you would fix MMS bugs, and at the same time, you already 
insists on not fixing this one. How am I supposed to trust you then?

Rémi Denis-Courmont

More information about the vlc-devel mailing list