[vlc-devel] [PATCH 1/2] libvlc: add equalizer API
jb at videolan.org
Mon Jul 22 16:47:03 CEST 2013
Le 13/07/2013 20:21, Mark Lee a écrit :
> To address review comments, this patch incorporates the following changes:
> * do not accept NULL for set_preamp and set_amp_at_index, document this in the
> method header, and change the test accordingly;
> * change the string concatentation implementation to use a single fixed length
> buffer - to be honest, I'm not sure what the preferred way is to do this.
> The final "tautology" comment is unclear to me, I think the code as-is is
> necessary but I will change it if it is explained further.
Ping for review :)
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device
More information about the vlc-devel