[vlc-devel] [PATCH] VLC Opus RTP/RTSP support

[Rémi Denis-Courmont]

On Wed, 24 Jul 2013 12:24:08 +0800, 常桓 <changyp6 at gmail.com> wrote:
> Hi All,
> I have summerized the codes from this guy
> http://lists.xiph.org/pipermail/opus/2012-November/001828.html
> and made a patch against vlc-2.0.7 release version.
> This patch enables Opus RTP decoding support in VLC.
> Patch is attached, please someone review this patch and merge it.

Patch without authoring informations cannot be merged. Also this needs to
be rebased to VLC 2.2 / master git.

Regardless, the patch looks very wrong to me. You cannot redefine the OPUS
FOURCC to mean RTP packets. RTP depayloading should occur in the demux, not
in the decoder. If it really needs to occur in the decoder rather than the
demux, then a separate FOURCC is required; but that should be avoided at
all costs as it will break stream output or alternative decoder
implementations.

-- 
Rémi Denis-Courmont
Sent from my collocated server