[vlc-devel] [RFC] dcp.cpp: Creation of access-demux module for DCP (using asdcplib)

[Jean-Baptiste Kempf]

On 03 Jun, Simona-Marinela Prodea wrote :
> The module only handles audio and video files in DCP, no subtitles yet. Is this form worthy of a patch?

Nice :) \o/

> + * Authors: 	Claire Etienne
> + *		Aurélie Sbinné
> + * 		Pierre Villard <pierre dot villard dot fr at gmail dot com>
> + * 		Samuel Kerjose
> + *		Julien Puyobro
> + *      Simona-Marinela Prodea <simona dot marinela dot prodea at gmail dot com>

No tabs in Source code.

> +//! DCP Structure
> +/*! This structure stores the most important information about the DCP */
> +struct dcp_t
> +{
> +    char *path;                /*!< Path to DCP directory */
> +    char *assetmapfile;        /*!< ASSETMAP XML file */
> +    char *pklfile;            /*!< PKL XML file name */
> +    char *cplfile;            /*!< CPL XML file name */
> +    char *videofile;        /*!< Video file name */
> +    char *audiofile;        /*!< Audio file name */
> +    int nb_files;            /*!< Number of files defined in ASSETMAP */
> +    file_t *files[50];        /*!< Files defined in ASSETMAP : we assume that there are less than 50 files */
> +};

Please align the comments.

> +    msg_Dbg( p_demux, "parserCplXML() in DCP Module : END" );

Not needed.

> +///////////////////////////////////////////////////////////////////////////////////////////
> +///////////////////////////////////////////////////////////////////////////////////////////
> +///////                                                                             ///////
> +///////     Low-level functions : Strings manipulations, Free function                ///////
> +///////                                                                                ///////
> +///////////////////////////////////////////////////////////////////////////////////////////
> +///////////////////////////////////////////////////////////////////////////////////////////

Are you sure this comment is not too small?

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device