[vlc-devel] [PATCH] Fix deinterlacing in transcode pipeline.

[Steinar H. Gunderson]

On Sat, Jun 08, 2013 at 11:22:16PM +0200, Steinar H. Gunderson wrote:
> I've made some changes: First and foremost, I've split this into five
> functionally separate patches. They should still be applied as a whole,
> but it will hopefully make the logic easier to follow. I also made some
> minor formatting fixups.

I forgot one of the changes in the previous patch set (the very first one).
Resending.

> Second, I figured that deinterlacing in the encoder's chroma would be a bad
> idea, since this is typically 4:2:0.

Also, I found a problem where the frame rate would be reset to the half rate
due to the extra conversion this could entail; ie., I converted UYVY 50fps ->
I422 50fps -> I420 25fps, since I420 25fps was the format of the encoder.
This is also fixed. (The fix is within 0004-In-video-etc.)

Finally, I'm seeing issues when --sout-transcode-threads is in use; I have
not figured out why this is, but maybe someone who knows this stuff better
than me can have a look.

New patch series attached.

/* Steinar */
-- 
Homepage: http://www.sesse.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-frame-rate-output-from-deinterlacer.patch
Type: text/x-diff
Size: 1040 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130609/4f1cdf81/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-In-transcoding-move-frame-output-into-its-own-functi.patch
Type: text/x-diff
Size: 9138 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130609/4f1cdf81/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Make-the-video-transcoder-support-filter-chains-that.patch
Type: text/x-diff
Size: 2601 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130609/4f1cdf81/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-In-video-transcode-use-the-correct-format-for-calcul.patch
Type: text/x-diff
Size: 6013 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130609/4f1cdf81/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-If-the-transcode-filter-chain-changes-the-format-not.patch
Type: text/x-diff
Size: 4501 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130609/4f1cdf81/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Fix-deinterlacing-of-packed-YUV-formats.patch
Type: text/x-diff
Size: 4117 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130609/4f1cdf81/attachment-0005.patch>