[vlc-devel] [PATCH] Fix deinterlacing in transcode pipeline.

[Rémi Denis-Courmont]

Le lundi 10 juin 2013 23:02:07, Steinar H. Gunderson a écrit :
> -- 
> Homepage: http://www.sesse.net/
> 0001-Fix-frame-rate-output-from-deinterlacer.patch
> 
> 0002-In-transcoding-move-frame-output-into-its-own-functi.patch

s/nad/and/

> 0003-Make-the-video-transcoder-support-filter-chains-that.patch

It would be a lot easier if there were a single chain. Oh well...

> 0004-In-video-transcode-use-the-correct-format-for-calcul.patch

Why does the frame rate get special treatment here? The comments insists on it 
but fails to give a rationale.

> 0005-Set-up-the-encoder-after-the-transcode-filter-chain.patch

That seems logical. However traditionally, VLC has initialized the "output" of 
the chain against the input format. Indeed, the same method is applied for 
regular video and audio filter chains.

I don't mind when it comes to transcode. But I gave up "fixing" this for audio; 
at the very least, it would have broken S/PDIF pass-through.

> 0006-Fix-deinterlacing-of-packed-YUV-formats.patch

Well, it works but ideally it would not be hard-coded in transcode. The same 
problem exists in the regular video output, but worse. I claim it is worse as 
the video output chroma cannot be forced like the stream output chroma 
(transcode{vcodec=I420}).

-- 
Rémi Denis-Courmont
http://www.remlab.net/