[vlc-devel] [PATCH] Fix deinterlacing in transcode pipeline.

[Steinar H. Gunderson]

On Tue, Jun 11, 2013 at 09:20:05PM +0300, Rémi Denis-Courmont wrote:
>> I guess the question here is: Do we want this to be the filter output
>> format with width/height/chroma/SAR/etc. changed, or the encoder input
>> format with the frame rate changed? I would guess they are mostly
>> equivalent, but there are a lot of changes done in
>> transcode_video_filter_init() that we'd need to pick up.
> If you create the filters before the encoder, this question should be moot.
> The encoder just gets the filtered format, including the filtered frame rate.

Yes; see my previous email. I've modified the patch set now; see attached.

>>>> 0005-Set-up-the-encoder-after-the-transcode-filter-chain.patch
>>> 
>>> That seems logical. However traditionally, VLC has initialized the
>>> "output" of the chain against the input format. Indeed, the same method
>>> is applied for regular video and audio filter chains.
>>> 
>>> I don't mind when it comes to transcode. But I gave up "fixing" this for
>>> audio; at the very least, it would have broken S/PDIF pass-through.
>> 
>> I'm not entirely sure what you are referring to here; by “output”, do you
>> mean the filter chain or the encoder?
> 
> I mean the object that gets the result of the filters chain, here in the 
> encoder.

OK, and by input format you mean the input of the filter chain?

> The filter chain code was supposed to solve this. But the unification was never 
> finished, and later the video output core was rewritten from scratch.
> 
> This should probably be unified like I did the audio filters recently. And 
> afterward, audio, video and sub filters should be partly unified. But that 
> sounds more like a world domination scheme than reality.

Well, yes, I think both this and adding chunked support to the deinterlacer
is outside the scope of my patch set. (Adding just support for some formats
sounds like it would be pretty suboptimal; add just two or three formats,
and someone's bound to need another one tomorrow, at which point you need the
conversion logic anyway...)

/* Steinar */
-- 
Homepage: http://www.sesse.net/