[vlc-devel] vlc_UrlParse: end username at the last @ rather than the first

Rémi Denis-Courmont remi at remlab.net
Sun Jun 16 15:33:26 CEST 2013

Le dimanche 16 juin 2013 16:05:58, Francois Cartegnie a écrit :
> You would usually reject that kind of workaround, no ?

There are huge work-arounds in the URL parsing and decoding code. For example, 
non-ASCII bytes are accepted by decode_URI(), even though they are clearly 
invalid. However, they cannot break a valid (corner) case. Valid hostnames or 
IP addresses do not contain @.

AFAICT, this change cannot break a valid use; in particular it will not break 
properly encoded usernames. Feel free to erase it, but at least Chroma works 
like that too.

Unfortunately, there are still quite many bugs in the URL handling of VLC (see 
section 5 of the RFC), most notably regarding reference resolution. This patch 
gets it neither closer nor further from correctness, I think.

Rémi Denis-Courmont

More information about the vlc-devel mailing list