[vlc-devel] [PATCH] Qt: get window icon from theme (falling back to existing pixmap)

Philip Sequeira phsequei at gmail.com
Wed Jun 19 12:04:04 CEST 2013

The window icon for the Qt4 interface is currently set from a (presumably old) 
32x32 xpm at compile time, and it looks pretty bad. It has aliasing problems 
(which is pretty much unavoidable as long as it's an xpm), and if the WM, DE, 
or whatever else wants a bigger icon for the window (for an icon-based 
Alt+Tab, maybe, or an OSX-style "Dock", or even just e.g. the mouseover on 
KDE's default taskbar), it has to upscale or stick the small icon in the 
middle, both of which look ugly.

This patch will try to get the appropriate icon from the icon theme, and fall 
back to the current pixmap if that fails. This way, it'll use the better icon 
that already ships with VLC, at all sizes available, and if the user's theme 
includes a replacement VLC icon, that'll be used instead (which was the object 
of ticket #6857, AFAICT).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Qt-get-window-icon-from-theme-falling-back-to-existi.patch
Type: text/x-patch
Size: 1049 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130619/867ca9b5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130619/867ca9b5/attachment.sig>

More information about the vlc-devel mailing list