[vlc-devel] [PATCH] OSX: don't open items twice

Rafaël Carré funman at videolan.org
Sun Jun 23 18:45:29 CEST 2013


Le 23/06/2013 15:53, David Fuhrmann a écrit :
> 
> Am 22.06.2013 um 15:22 schrieb Rafaël Carré <funman at videolan.org>:
> 
>> Closes: #8611
>> ---
>> modules/gui/macosx/intf.m | 27 ++++++++++++++++++++++-----
>> 1 file changed, 22 insertions(+), 5 deletions(-)

> Hi,

Hello,

> I was hoping that a more clean solution can be found, but this hack will probably work, too.
> As it seems, only all items from the second one onwards are duplicated, not the first one.

I noticed it, I was wondering if it was caused by the code running
input_AddSubtitle, or some peculiarity of OSX command line processing.

> I am not sure if this can be an issue in this scenario, but you might want to decrease the variable by [o_names count], to be on the safe side.

True, although it is always 1 when running from command line (I suppose
it's more when you D&D several files on the dock icon)

> And, auto start of the items added by command line is now completely broken with this patch, but that is another issue, and it was already quite ugly before.

Perhaps it's the occasion to figure out what's wrong :)

> With best regards,
> David




More information about the vlc-devel mailing list